From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <a@unstable.cc>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header
Date: Wed, 11 May 2016 14:24:04 +0200 [thread overview]
Message-ID: <5284085.o6G6OjSAFN@bentobox> (raw)
In-Reply-To: <20160511104730.GB21549@prodigo.lan>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Wednesday 11 May 2016 18:47:30 Antonio Quartulli wrote:
[...]
> Maybe I could include it only when really needed, i.e.
> * net/batman-adv/bat_algo.h
> * net/batman-adv/bat_v_ogm.h
>
> (netlink.h does not seem to be requiring it)
This is rather vague and hard to detect automatically. Potentially all
files may require it because it has things like:
/* Debug Messages */
#ifdef pr_fmt
#undef pr_fmt
#endif
/* Append 'batman-adv: ' before kernel messages */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Btw. Just looked at this file again and I should really consider
redoing/rebasing the patches [1,2] from Markus Pargmann to clean it up.
Kind regards,
Sven
[1] https://patchwork.open-mesh.org/patch/4264/
[2] https://patchwork.open-mesh.org/patch/4244/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-11 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 10:29 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header Antonio Quartulli
2016-05-11 10:29 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: B.A.T.M.A.N. V - implement hard-iface init function Antonio Quartulli
2016-05-11 13:11 ` Sven Eckelmann
2016-05-11 21:14 ` Antonio Quartulli
2016-05-11 10:38 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove forward declaration by including proper header Sven Eckelmann
2016-05-11 10:47 ` Antonio Quartulli
2016-05-11 12:24 ` Sven Eckelmann [this message]
2016-05-12 21:07 ` Antonio Quartulli
2016-05-12 22:45 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284085.o6G6OjSAFN@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox