Re: [B.A.T.M.A.N.] [PATCHv2 1/6] batman-adv: add isolation_mark sysfs attribute

Antonio Quartulli
2013-11-16T09:10:21Z

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

On Sat, Nov 16, 2013 at 01:35:53PM +0800, Marek Lindner wrote:
> On Wednesday 13 November 2013 17:38:00 Antonio Quartulli wrote:
> > @@ -692,6 +692,8 @@ static int batadv_softif_init_late(struct net_device
> > *dev)>
> > #endif
> >
> > bat_priv->tt.last_changeset = NULL;
> > bat_priv->tt.last_changeset_len = 0;
> >
> > + bat_priv->isolation_mark = 0;
> > + bat_priv->isolation_mark_mask = 0;
> >
> > /* randomize initial seqno to avoid collision */
> > get_random_bytes(&random_seqno, sizeof(random_seqno));
>
> Wasn't the plan to initialize isolation_mark_mask with something useful like
> 0xFFFFFFFF ?

Uhm, no. The plan is that when the user enters a value _without_ specifying a
mask, then we assume the mask is 0xFFFFFFFF (this is what mask = UINT_MAX does
in the next few lines).

During initialization isolation_mark_mask must be 0 because this means "extended
isolation is off".

[...]

> > +static ssize_t batadv_store_isolation_mark(struct kobject *kobj,
> > + struct attribute *attr, char *buff,
> > + size_t count)
> > +{
> > + struct net_device *net_dev = batadv_kobj_to_netdev(kobj);
> > + struct batadv_priv *bat_priv = netdev_priv(net_dev);
> > + uint32_t mark, mask = UINT_MAX;
> > + char *mask_ptr;

[...]

> We always have 'show' before 'store' in the sysfs.c file. Please keep the
> order.

Ok, will do.

>
> Where is the sysfs documentation update ?

Oh, right. I totally forgot about that. Thanks!

Cheers,

--
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]