Re: [B.A.T.M.A.N.] [PATCHv2 2/6] batman-adv: mark a local client as isolated when needed

Antonio Quartulli
2013-11-16T10:43:10Z

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

On Sat, Nov 16, 2013 at 11:04:15AM +0100, Martin Hundebøll wrote:
> On 2013-11-16 10:11, Antonio Quartulli wrote:
> > On Sat, Nov 16, 2013 at 01:31:11PM +0800, Marek Lindner wrote:
> >> On Wednesday 13 November 2013 17:38:01 Antonio Quartulli wrote:
> >>> @@ -474,7 +474,7 @@ static void batadv_tt_global_free(struct batadv_priv
> >>> *bat_priv, * Returns true if the client was successfully added, false
> >>> otherwise. */
> >>> bool batadv_tt_local_add(struct net_device *soft_iface, const uint8_t
> >>> *addr, - unsigned short vid, int ifindex)
> >>> + unsigned short vid, int ifindex, uint32_t mark)
> >>> {
> >>> struct batadv_priv *bat_priv = netdev_priv(soft_iface);
> >>> struct batadv_tt_local_entry *tt_local;
> >>
> >> Kernel doc ?
> >
> > argh, I tried to escape the kerneldoc tradition :D
>
> We should make a patch to checkpatch to check for kerneldoc :)

why not :) we can have "per-path" rules. So we can specify our rules for
net/batman-adv/...Thanks for volunteering!

Cheers,

--
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]