[B.A.T.M.A.N.] [PATCH] batman-adv: use batadv_compare_eth when possible

[B.A.T.M.A.N.] [PATCH] batman-adv: use batadv_compare_eth when possible

[Antonio Quartulli]

When comparing Ethernet address it is better to use the more
generic batadv_compare_eth. The latter is also optimised for
architectures having a fast unaligned access.

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 network-coding.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/network-coding.c b/network-coding.c
index f1b604d..0049e7a 100644
--- a/network-coding.c
+++ b/network-coding.c
@@ -481,12 +481,10 @@ static int batadv_nc_hash_compare(const struct hlist_node *node,
 	nc_path2 = data2;
 
 	/* Return 1 if the two keys are identical */
-	if (memcmp(nc_path1->prev_hop, nc_path2->prev_hop,
-		   sizeof(nc_path1->prev_hop)) != 0)
+	if (!batadv_compare_eth(nc_path1->prev_hop, nc_path2->prev_hop))
 		return 0;
 
-	if (memcmp(nc_path1->next_hop, nc_path2->next_hop,
-		   sizeof(nc_path1->next_hop)) != 0)
+	if (!batadv_compare_eth(nc_path1->next_hop, nc_path2->next_hop))
 		return 0;
 
 	return 1;
-- 
1.8.5.2

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use batadv_compare_eth when possible

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

On 05/01/14 12:36, Antonio Quartulli wrote:
> When comparing Ethernet address it is better to use the more
> generic batadv_compare_eth. The latter is also optimised for
> architectures having a fast unaligned access.
> 
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>

Martin,

I forgot to add you to the CC list :) Sorry!


Cheers,


-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use batadv_compare_eth when possible

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

On Sunday 05 January 2014 12:36:49 Antonio Quartulli wrote:
> When comparing Ethernet address it is better to use the more
> generic batadv_compare_eth. The latter is also optimised for
> architectures having a fast unaligned access.
> 
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---

It looks like this patch doesn't apply anymore. Can you please resent it or
mark it correctly in patchwork [1].

But for the cleanup:

Acked-by: Sven Eckelmann <sven@narfation.org>

Thanks,
        Sven

[1] https://patchwork.open-mesh.org/patch/3769/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]