From: Antonio Quartulli <antonio@meshcoding.com>
To: "Linus Lüssing" <linus.luessing@web.de>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: use eth_hdr() instead of skb->data in interface_tx path
Date: Thu, 16 Jan 2014 22:07:23 +0100 [thread overview]
Message-ID: <52D84A0B.5050700@meshcoding.com> (raw)
In-Reply-To: <1389832761-7914-1-git-send-email-linus.luessing@web.de>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
Hi Linus!
On 16/01/14 01:39, Linus Lüssing wrote:
> + if ((struct ethhdr *)skb->data != eth_hdr(skb)) {
> + pr_warn("Upper device did not set the ethernet header pointer correctly - adjusting\n");
> + skb_reset_mac_header(skb);
> + }
I think that if we really want to properly set the mac_header we should
just do it and forget about the if and about the warning.
It's a really "stupid" operation and in the end we have many spots in
the kernel where the pointers are just set without adding too much
overhead like messages or other things...
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-01-16 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 0:39 [B.A.T.M.A.N.] [PATCHv2] batman-adv: use eth_hdr() instead of skb->data in interface_tx path Linus Lüssing
2014-01-16 19:06 ` Marek Lindner
2014-01-16 21:07 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D84A0B.5050700@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox