From: Antonio Quartulli <antonio@meshcoding.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: use eth_hdr() instead of skb->data in interface_tx path
Date: Sun, 19 Jan 2014 11:15:58 +0100 [thread overview]
Message-ID: <52DBA5DE.9000609@meshcoding.com> (raw)
In-Reply-To: <1390086967-6047-2-git-send-email-linus.luessing@web.de>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On 19/01/14 00:16, Linus Lüssing wrote:
> Our .ndo_start_xmit handler (batadv_interface_tx()) can rely on having
> the skb ether header pointer set correctly since the following commit
> present in kernels >= 3.9:
>
> "net: reset mac header in dev_start_xmit()" (6d1ccff627)
>
> Therefore we can safely use eth_hdr() instead of skb->data now, which
> spares us some ugly type casts.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Linus,
in interface_tx() we also have an assignment for vlan_hdr getting the
value of skb->data as well.
Would you mind switching it to vlan_eth_hdr() ?
Maybe you can have a quick look whether there are other occurrences to
change within interface_tx()?
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-19 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 23:16 [B.A.T.M.A.N.] eth_hdr/skb_reset_mac_header changes Linus Lüssing
2014-01-18 23:16 ` [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: use eth_hdr() instead of skb->data in interface_tx path Linus Lüssing
2014-01-19 10:15 ` Antonio Quartulli [this message]
2014-01-18 23:16 ` [B.A.T.M.A.N.] [PATCHv5 2/2] batman-adv: remove obsolete skb_reset_mac_header() in batadv_bla_tx() Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DBA5DE.9000609@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox