On 17/01/14 10:37, Sven Eckelmann wrote:
> On Thursday 16 January 2014 22:11:38 Antonio Quartulli wrote:
>> I think that it may still be the case that we want to compile batctl on
>> an host without libnl.
> 
> We == "I have this use case"?
> 
>> In the end batman-adv can run on Ethernet and we may have an embedded
>> system with no wifi which has no libnl at all.
> 
> (Now a little bit sarcasm): batctl can also run without batman-adv, please 
> allow to drop the useless sysfs/debugfs stuff ;)
> 
>> I was wondering....what if we check if libnl is installed or not and in
>> case it is missing we disable the address translation and vlan operations?
>> In this way we can add the dependency to libnl and avoid code
>> duplication but at the same time we keep libnl-free users happy.
> 
> I agree that it is possible but would like to avoid to provide a "fallback" 
> because it justs adds more complexity without an actual use case (please 
> correct me but I don't see it right now).
> 

My use case was only about an embedded device (e.g. raspberry pi) having
an Eth connection but no wireless at all, thus it may not have libnl.

> If you still think it is necessary then please feel free to add it later.
> 

Anyway I agree with you: that requires too much complexity for a very
little gain.

I like this patchset as it is.

Thanks.

Cheers,


-- 
Antonio Quartulli