From: Antonio Quartulli <antonio@meshcoding.com>
To: Russell Senior <russell@personaltelco.net>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix soft-interface MTU computation
Date: Tue, 21 Jan 2014 20:00:31 +0100 [thread overview]
Message-ID: <52DEC3CF.4020608@meshcoding.com> (raw)
In-Reply-To: <86mwipch0u.fsf@coulee.tdb.com>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
On 21/01/14 19:43, Russell Senior wrote:
>>>>>> "Antonio" == Antonio Quartulli <antonio@meshcoding.com> writes:
>
> Antonio> The current MTU computation always returns a value smaller
> Antonio> than 1500bytes even if the real interfaces have an MTU large
> Antonio> enough to compensate the batman-adv overhead.
>
> Antonio> Fix the computation by properly returning the highest
> Antonio> admitted value.
>
> Antonio> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com> ---
>
> This seems to fix the bat0-MTU-unnecessarily-small problem I observed
> last night and reported on the IRC channel. I haven't actually passed
> any traffic over it yet, but the interface is up with the expected MTU
> value with the patch.
Just to be sure the fix is not introducing any misbehaviour: have you
tried setting smaller MTUs to your hard interface? In that case have you
seen the bat0 reducing its MTU?
>
> Antonio> This patch is missing a Reported-by clause because I did not
> Antonio> have "russell"'s email address at hand.
>
> Antonio> Will be added later before being merged.
>
> Reported-by: Russell Senior <russell@personaltelco.net>
I'd also add Tested-by ;)
Thanks a lot!
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-21 19:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 10:22 [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix soft-interface MTU computation Antonio Quartulli
2014-01-21 10:31 ` Antonio Quartulli
2014-01-27 7:57 ` Marek Lindner
2014-01-21 18:43 ` Russell Senior
2014-01-21 19:00 ` Antonio Quartulli [this message]
2014-01-22 6:04 ` Russell Senior
2014-01-22 7:03 ` Antonio Quartulli
2014-01-22 7:04 ` [B.A.T.M.A.N.] memleak (Was: [PATCH maint] batman-adv: fix soft-interface MTU computation) Antonio Quartulli
2014-01-22 7:37 ` [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix soft-interface MTU computation Daniel
2014-01-22 17:45 ` [B.A.T.M.A.N.] batman-adv: memory leak? Russell Senior
2014-01-22 17:46 ` Antonio Quartulli
2014-01-22 19:18 ` Russell Senior
2014-01-22 20:49 ` cmsv
2014-01-22 23:57 ` Russell Senior
2014-01-23 0:10 ` cmsv
2014-01-23 3:35 ` Daniel
2014-01-26 12:57 ` Daniel
2014-01-26 14:21 ` Antonio Quartulli
2014-01-26 14:24 ` [B.A.T.M.A.N.] [PATCH maint] batman-adv: release vlan object after checking the CRC Antonio Quartulli
2014-01-27 18:43 ` Russell Senior
2014-01-26 16:05 ` [B.A.T.M.A.N.] batman-adv: memory leak? cmsv
2014-01-26 16:07 ` Antonio Quartulli
2014-01-26 16:13 ` Antonio Quartulli
2014-01-27 17:55 ` cmsv
2014-01-28 1:21 ` Russell Senior
2014-01-28 1:30 ` cmsv
2014-01-29 8:10 ` Russell Senior
2014-01-29 21:48 ` cmsv
2014-02-08 3:08 ` cmsv
2014-02-08 10:53 ` Felix Fietkau
2014-02-12 7:23 ` Antonio Quartulli
2014-02-12 10:40 ` cmsv
2014-02-12 11:41 ` Antonio Quartulli
2014-02-13 0:55 ` cmsv
2014-02-13 7:23 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DEC3CF.4020608@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=russell@personaltelco.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox