From: Antonio Quartulli <antonio@meshcoding.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 next] batman-adv: avoid potential race condition when adding a new neighbour
Date: Wed, 29 Jan 2014 11:21:22 +0100 [thread overview]
Message-ID: <52E8D622.8080902@meshcoding.com> (raw)
In-Reply-To: <3034509.GXq9lutoyG@diderot>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On 29/01/14 05:40, Marek Lindner wrote:
> On Monday 27 January 2014 16:27:17 Antonio Quartulli wrote:
>> @@ -266,7 +266,7 @@ batadv_iv_ogm_neigh_new(struct batadv_hard_iface
>> *hard_iface, struct batadv_orig_node *orig_neigh)
>> {
>> struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
>> - struct batadv_neigh_node *neigh_node;
>> + struct batadv_neigh_node *neigh_node = NULL, *tmp_neigh_node;
>>
>> neigh_node = batadv_neigh_node_new(hard_iface, neigh_addr,
>> orig_node);
>
> I don't quite get why neigh_node has to be initialized if we set a value in
> the next line.
nice catch :)
That's probably a residual from a previous approach I was trying out.
I'll send v4 soon.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-01-29 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 15:27 [B.A.T.M.A.N.] [PATCHv3 next] batman-adv: avoid potential race condition when adding a new neighbour Antonio Quartulli
2014-01-29 4:40 ` Marek Lindner
2014-01-29 10:21 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E8D622.8080902@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox