Re: [B.A.T.M.A.N.] [PATCH next 03/11] batman-adv: fix multicast kerneldoc

Antonio Quartulli
2014-03-17T16:32:35Z

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On 17/03/14 17:13, Martin Hundebøll wrote:
>> - * If so then return 0. Otherwise -EINVAL is returned or -ENOMEM if we are
>> - * out of memory.
>> + * If so then returns 0. Otherwise -EINVAL is returned or -ENOMEM if we are out
>> + * of memory.
>> */
>
> The commit message says you wanted to use third person singular, but
> your change keeps the "we are out of memory" ?

I meant to use third person singular when talking about the action made
by the function.

Saying "we" in the code/comment is generally not nice..maybe should
change that as well.

Cheers,

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]