Re: [B.A.T.M.A.N.] [PATCH next 03/11] batman-adv: fix multicast kerneldoc

Martin Hundebøll
2014-03-17T16:13:34Z

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

Hi Antonio,

On 2014-03-17 06:22, Antonio Quartulli wrote:
> The kerneldoc should always use the third person singular in
> the long function description.
> Moreover it should always try use up to 80 chars per line.
>
> Introduced by 86cb16e5ec1e2d75821006e8f4abbec66fb741ac
> ("batman-adv: Add IPv4 link-local/IPv6-ll-all-nodes multicast support")
>
> Cc: Linus Lüssing <linus.luessing@web.de>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
> multicast.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/multicast.c b/multicast.c
> index af3fe49..0e8bea8 100644
> --- a/multicast.c
> +++ b/multicast.c
> @@ -256,11 +256,11 @@ out:
> * @skb: the IPv4 packet to check
> * @is_unsnoopable: stores whether the destination is snoopable
> *
> - * Check whether the given IPv4 packet has the potential to
> - * be forwarded with a mode more optimal than classic flooding.
> + * Checks whether the given IPv4 packet has the potential to be forwarded with a
> + * mode more optimal than classic flooding.
> *
> - * If so then return 0. Otherwise -EINVAL is returned or -ENOMEM if we are
> - * out of memory.
> + * If so then returns 0. Otherwise -EINVAL is returned or -ENOMEM if we are out
> + * of memory.
> */

The commit message says you wanted to use third person singular, but
your change keeps the "we are out of memory" ?

--
Kind Regards
Martin Hundebøll
Frederiks Allé 99, 1.th
8000 Aarhus C
Denmark

+45 61 65 54 61
martin@hundeboll.net

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]