From: Antonio Quartulli <antonio@meshcoding.com>
To: "Martin Hundebøll" <martin@hundeboll.net>,
"The list for a Better Approach To Mobile Ad-hoc Networking"
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH next 03/11] batman-adv: fix multicast kerneldoc
Date: Mon, 17 Mar 2014 17:32:35 +0100 [thread overview]
Message-ID: <532723A3.5080808@meshcoding.com> (raw)
In-Reply-To: <53271F2E.6030307@hundeboll.net>
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
On 17/03/14 17:13, Martin Hundebøll wrote:
>> - * If so then return 0. Otherwise -EINVAL is returned or -ENOMEM if we are
>> - * out of memory.
>> + * If so then returns 0. Otherwise -EINVAL is returned or -ENOMEM if we are out
>> + * of memory.
>> */
>
> The commit message says you wanted to use third person singular, but
> your change keeps the "we are out of memory" ?
I meant to use third person singular when talking about the action made
by the function.
Saying "we" in the code/comment is generally not nice..maybe should
change that as well.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-03-17 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 13:22 [B.A.T.M.A.N.] [PATCH next 01/11] batman-adv: remove useless goto Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 02/11] batman-adv: don't mess up with the netdev refcounting if not needed Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 03/11] batman-adv: fix multicast kerneldoc Antonio Quartulli
2014-03-17 16:13 ` Martin Hundebøll
2014-03-17 16:32 ` Antonio Quartulli [this message]
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 04/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 05/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 06/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 07/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 08/11] batman-adv: adjust copyright disclaimer in multicast files Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 09/11] batman-adv: fix code style Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 10/11] batman-adv: fix more " Antonio Quartulli
2014-03-17 16:19 ` Martin Hundebøll
2014-03-17 16:33 ` Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 11/11] " Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532723A3.5080808@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=martin@hundeboll.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox