From: Sven Eckelmann <sven@narfation.org>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 7/9] batman-adv-devel: Add missing TARGET_* flags to batctl compile
Date: Wed, 08 May 2013 09:24:50 +0200 [thread overview]
Message-ID: <5327945.UAE3F7hzx2@bentobox> (raw)
In-Reply-To: <201305081311.57379.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Wednesday 08 May 2013 13:11:57 Marek Lindner wrote:
> On Tuesday, May 07, 2013 20:51:07 Sven Eckelmann wrote:
> > The compilation step of batctl completely dropped the TARGET_CFLAGS,
> > TARGET_CPPFLAGS and TARGET_LDFLAGS and therefore weren't compiled and
> > linked with the flags given by the OpenWRT build environment.
>
> It seems you missed the meaning of MAKE_BATCTL_ARGS ? This variable contains
> TARGET_CFLAGS already. We apparently are missing TARGET_CPPFLAGS and
> TARGET_LDFLAGS. Do you want to resend and make the necessary changes to
> MAKE_BATCTL_ARGS ?
I didn't felt like fixing your other problems too, but sent two other patches
resolving the MAKE_BATCTL_ARGS problem. See
[Bonus-PATCH 10/9] batman-adv-devel: Don't overwrite batctl's CFLAGS
[Bonus-PATCH 11/9] batman-adv-devel: Remove unused parameters from
MAKE_BATCTL_ARGS
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-08 7:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 12:51 [B.A.T.M.A.N.] [PATCH 0/9] Adding size relevant build options Sven Eckelmann
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 1/9] alfred: Add CFLAGS to the linker step Sven Eckelmann
2013-05-14 9:41 ` Simon Wunderlich
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 2/9] batctl: " Sven Eckelmann
2013-05-08 5:04 ` Marek Lindner
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 3/9] batmand: " Sven Eckelmann
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 4/9] vis: " Sven Eckelmann
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 5/9] alfred: Use section garbage collection to reduce binary size Sven Eckelmann
2013-05-14 9:44 ` Simon Wunderlich
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 6/9] alfred: Enable Link-time optimization Sven Eckelmann
2013-05-14 9:45 ` Simon Wunderlich
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 7/9] batman-adv-devel: Add missing TARGET_* flags to batctl compile Sven Eckelmann
2013-05-08 5:11 ` Marek Lindner
2013-05-08 7:24 ` Sven Eckelmann [this message]
2013-05-12 7:52 ` Marek Lindner
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 8/9] batman-adv-devel: Use section garbage collection to reduce binary size Sven Eckelmann
2013-05-12 8:20 ` Marek Lindner
2013-05-07 12:51 ` [B.A.T.M.A.N.] [PATCH 5/9] batman-adv-devel: Enable Link-time optimization Sven Eckelmann
2013-05-12 8:21 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5327945.UAE3F7hzx2@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox