From: Sven Eckelmann <sven@narfation.org>
To: sashiko-reviews@lists.linux.dev
Cc: sw@simonwunderlich.de, antonio@mandelbit.com,
marek.lindner@mailbox.org, b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH batadv v2 6/8] batman-adv: tt: don't queue local events for unhashed entries
Date: Thu, 08 Oct 2026 17:13:45 +0200 [thread overview]
Message-ID: <5334040.31r3eYUQgx@sven-desktop> (raw)
In-Reply-To: <sashiko-outbox-164327@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Thursday, 8 October 2026 16:51:45 CEST sashiko-bot@kernel.org wrote:
> [Severity: Low]
> Should this update include an atomic_inc(&hash->generation) similar to how it
> is handled in batadv_tt_local_remove_now()?
>
> If batadv_tt_local_dump() is preempted during a netlink dump and resumes
> in the middle of a hash bucket while batadv_tt_local_purge_pending_clients()
> concurrently removes an entry, the dump offset will be shifted.
>
> Without incrementing the hash generation counter here, cb->seq remains
> unchanged and netlink won't set NLM_F_DUMP_INTR. Does this allow userspace
> to silently skip elements in the dump without being warned of the
> inconsistency?
Pre-existing problem and not introduced in this change.
https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20261008-tt-hash-generatopn-v1-1-5aa687343ce1@narfation.org/
Regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-10-08 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 14:30 [PATCH batadv v2 0/8] batman-adv: tt: shashiko 20260930 follow ups Sven Eckelmann
2026-10-08 14:30 ` [PATCH batadv v2 1/8] batman-adv: tt: only transmit local ROAM flag together with DEL Sven Eckelmann
2026-10-08 14:30 ` [PATCH batadv v2 2/8] batman-adv: tt: clear ROAM flag when re-adding a pending local client Sven Eckelmann
2026-10-08 14:30 ` [PATCH batadv v2 3/8] batman-adv: tt: send ROAM_ADV on each roamed back client Sven Eckelmann
2026-10-08 14:30 ` [PATCH batadv v2 4/8] batman-adv: tt: ignore ROAM flag of received ADD changes Sven Eckelmann
2026-10-08 14:30 ` [PATCH batadv v2 5/8] batman-adv: tt: only update flags for TT events Sven Eckelmann
[not found] ` <sashiko-outbox-164321@kernel.org>
2026-10-08 15:02 ` Sven Eckelmann
2026-10-08 14:30 ` [PATCH batadv v2 6/8] batman-adv: tt: don't queue local events for unhashed entries Sven Eckelmann
[not found] ` <sashiko-outbox-164327@kernel.org>
2026-10-08 15:13 ` Sven Eckelmann [this message]
2026-10-08 14:30 ` [PATCH batadv v2 7/8] batman-adv: tt: avoid list_lock for unchanged local clients Sven Eckelmann
2026-10-08 14:30 ` [PATCH batadv v2 8/8] batman-adv: tt: drop ADD+DEL events of never announced clients Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5334040.31r3eYUQgx@sven-desktop \
--to=sven@narfation.org \
--cc=antonio@mandelbit.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=marek.lindner@mailbox.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox