Re: [B.A.T.M.A.N.] [PATCH 1/7] cfg80211: export expected throughput through get_station()

Johannes Berg
2014-04-25T15:44:12Z

On Mon, 2014-04-14 at 16:03 +0200, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
>
> Users may need information about the expected throughput

I think this "expected throughput" should be a bit clarified.

Are you talking about "expected PHY rate" or rather "expected (payload)
throughput"?

> towards a given peer computed by the RC algorithm.
> Export such value in Mbps/100 through the get_station() API.

"units of 10Kbps" might be a better description :-)

> This unit has been chosen because it is the same of the
> throughput returned by MinstrelHT.

Since it's unlikely we'll ever reach the limit of a u32, maybe just
multiply by 10 to get the nicer Kbps?

> + * @expected_throughput: expected throughput in Mbps/100 reported by the RC
> + * algorithm towards this station. The unit of this value has been chosen
> + * because it is the same of the throughput returned by MinstrelHT

I think the rationale shouldn't be here now.

johannes