Re: [B.A.T.M.A.N.] [PATCH 2/7] mac80211: add get_expected_throughput API

Antonio Quartulli
2014-05-14T21:09:23Z

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

On 25/04/14 17:44, Johannes Berg wrote:
> On Mon, 2014-04-14 at 16:03 +0200, Antonio Quartulli wrote:
>
>> + u32 (*get_expected_throughput)(struct ieee80211_sta *sta);
>
> This isn't nice - it forces drivers to conjure up a value.
>
> You should probably at least allow returning 0 for "no idea" or
> something.

Yeah, I think so too. Returning 0 as "I don't know what to provide"
should be fine. I will specify this in the doc.

Cheers,

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]