From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v3 3/6] batman-adv: split tvlv into a separate file
Date: Fri, 20 May 2016 16:58:01 +0800 [thread overview]
Message-ID: <5391263.p0XQNe6lIm@voltaire> (raw)
In-Reply-To: <1463303266-25979-3-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]
On Sunday, May 15, 2016 11:07:43 Sven Eckelmann wrote:
> From: Markus Pargmann <mpa@pengutronix.de>
>
> The tvlv functionality in main.c is mostly unrelated to the rest of the
> content. It still takes up a large portion of this source file (~45%, 588
> lines). Moving it to a separate file makes it better visible as a main
> component of the batman-adv implementation and hides it less in the other
> helper functions in main.c
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> [sven@narfation.org: fix conflicts with current version, fix includes,
> rewrote commit message]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v3:
> - Patch was resurrected from https://patchwork.open-mesh.org/patch/4244/
> - rewrote commit message
> - fixed conflicts
> - fixed includes
> ---
> net/batman-adv/Makefile | 1 +
> net/batman-adv/bat_iv_ogm.c | 1 +
> net/batman-adv/bat_v_ogm.c | 1 +
> net/batman-adv/distributed-arp-table.c | 1 +
> net/batman-adv/gateway_common.c | 1 +
> net/batman-adv/main.c | 591
> -------------------------------
> net/batman-adv/main.h | 34 --
> net/batman-adv/multicast.c | 1 +
> net/batman-adv/network-coding.c | 1 +
> net/batman-adv/routing.c | 1 +
> net/batman-adv/translation-table.c | 1 +
> net/batman-adv/tvlv.c | 630
> +++++++++++++++++++++++++++++++++
> net/batman-adv/tvlv.h | 61 ++++
> 13 files changed, 700 insertions(+), 625 deletions(-)
> create mode 100644 net/batman-adv/tvlv.c
> create mode 100644 net/batman-adv/tvlv.h
Applied in revision 65326e3.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-20 8:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 9:07 [B.A.T.M.A.N.] [PATCH v3 1/6] batman-adv: Include main.h in all files Sven Eckelmann
2016-05-15 9:07 ` [B.A.T.M.A.N.] [PATCH v3 2/6] batman-adv: Keep includes ordered by filename Sven Eckelmann
2016-05-20 8:55 ` Marek Lindner
2016-05-15 9:07 ` [B.A.T.M.A.N.] [PATCH v3 3/6] batman-adv: split tvlv into a separate file Sven Eckelmann
2016-05-20 8:58 ` Marek Lindner [this message]
2016-05-15 9:07 ` [B.A.T.M.A.N.] [PATCH v3 4/6] batman-adv: move bat_algo functions " Sven Eckelmann
2016-05-20 9:08 ` Marek Lindner
2016-05-15 9:07 ` [B.A.T.M.A.N.] [PATCH v3 5/6] batman-adv: Consolidate logging related functions Sven Eckelmann
2016-05-15 21:48 ` [B.A.T.M.A.N.] [PATCH] " Sven Eckelmann
2016-05-20 9:15 ` Marek Lindner
2016-05-15 9:07 ` [B.A.T.M.A.N.] [PATCH v3 6/6] batman-adv: Fix bat_(iv|v) function declaration header Sven Eckelmann
2016-05-20 9:18 ` Marek Lindner
2016-05-20 8:52 ` [B.A.T.M.A.N.] [PATCH v3 1/6] batman-adv: Include main.h in all files Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5391263.p0XQNe6lIm@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox