Re: [B.A.T.M.A.N.] [PATCH] remove unnecessary logspam

[Antonio Quartulli <antonio@meshcoding.com>]

[-- Attachment #1: Type: text/plain, Size: 4288 bytes --]

Hi André,

On 09/06/14 23:36, André Gaul wrote:
> Hey Antonio,
> 
> thx for your quick reply!
> 
> Am 09.06.2014 23:05, schrieb Antonio Quartulli:
>> I'd suggest you to check this patch with checkpatch.pl --strict. Here I
>> get many errors due to non-printable chars at the end of various lines.
> 

This is my output (this is checkpatch from net-next) - you can ignore
the warnings about "Macros with complex values should be enclosed in
parenthesis":

$ ./exp/linux-merge/scripts/checkpatch.pl --strict \[B.A.T.M.A.N.\]\
\[PATCH\]\ remove\ unnecessary\ logspam.eml
ERROR: DOS line endings
#111: FILE: main.h:242:
+/* possibly ratelimited debug output */^M$

ERROR: DOS line endings
#112: FILE: main.h:243:
+#define _batadv_dbg(type, bat_priv, ratelimited, fmt, arg...)^I\^M$

WARNING: Whitespace after \ makes next lines useless
#112: FILE: main.h:243:
+#define _batadv_dbg(type, bat_priv, ratelimited, fmt, arg...)	\

ERROR: Macros with complex values should be enclosed in parenthesis
#112: FILE: main.h:243:
+#define _batadv_dbg(type, bat_priv, ratelimited, fmt, arg...)	\

ERROR: DOS line endings
#115: FILE: main.h:245:
+^I^Iif (atomic_read(&bat_priv->log_level) & type && \^M$

ERROR: DOS line endings
#116: FILE: main.h:246:
+^I^I    (!ratelimited || net_ratelimit()))^I^I\^M$

ERROR: DOS line endings
#125: FILE: main.h:251:
+__printf(4, 5)^M$

ERROR: DOS line endings
#126: FILE: main.h:252:
+static inline void _batadv_dbg(int type __always_unused,^M$

ERROR: DOS line endings
#127: FILE: main.h:253:
+^I^I^I       struct batadv_priv *bat_priv __always_unused,^M$

ERROR: DOS line endings
#128: FILE: main.h:254:
+^I^I^I       int ratelimited __always_unused,^M$

ERROR: DOS line endings
#129: FILE: main.h:255:
+^I^I^I       const char *fmt __always_unused, ...)^M$

ERROR: DOS line endings
#134: FILE: main.h:260:
+#define batadv_dbg(type, bat_priv, arg...) \^M$

WARNING: Whitespace after \ makes next lines useless
#134: FILE: main.h:260:
+#define batadv_dbg(type, bat_priv, arg...) \

ERROR: Macros with complex values should be enclosed in parenthesis
#134: FILE: main.h:260:
+#define batadv_dbg(type, bat_priv, arg...) \

ERROR: DOS line endings
#135: FILE: main.h:261:
+^I_batadv_dbg(type, bat_priv, 0, ## arg)^M$

ERROR: DOS line endings
#136: FILE: main.h:262:
+#define batadv_dbg_ratelimited(type, bat_priv, arg...) \^M$

WARNING: Whitespace after \ makes next lines useless
#136: FILE: main.h:262:
+#define batadv_dbg_ratelimited(type, bat_priv, arg...) \

ERROR: Macros with complex values should be enclosed in parenthesis
#136: FILE: main.h:262:
+#define batadv_dbg_ratelimited(type, bat_priv, arg...) \

ERROR: DOS line endings
#137: FILE: main.h:263:
+^I_batadv_dbg(type, bat_priv, 1, ## arg)^M$

ERROR: DOS line endings
#138: FILE: main.h:264:
+^M$

ERROR: DOS line endings
#155: FILE: routing.c:709:
+^I^I^Ibatadv_dbg_ratelimited(BATADV_DBG_TT,^M$

ERROR: DOS line endings
#156: FILE: routing.c:710:
+^I^I^I^I^I       bat_priv,^M$

ERROR: DOS line endings
#157: FILE: routing.c:711:
+^I^I^I^I^I       "Rerouting unicast packet to %pM (dst=%pM): Local
Roaming\n",^M$

ERROR: DOS line endings
#158: FILE: routing.c:712:
+^I^I^I^I^I       unicast_packet->dest,^M$

ERROR: DOS line endings
#159: FILE: routing.c:713:
+^I^I^I^I^I       ethhdr->h_dest);^M$

ERROR: DOS line endings
#171: FILE: routing.c:755:
+^I^Ibatadv_dbg_ratelimited(BATADV_DBG_TT, bat_priv,^M$

ERROR: DOS line endings
#172: FILE: routing.c:756:
+^I^I^I^I       "Rerouting unicast packet to %pM (dst=%pM): TTVN
mismatch old_ttvn=%u new_ttvn=%u\n",^M$

ERROR: DOS line endings
#173: FILE: routing.c:757:
+^I^I^I^I       unicast_packet->dest, ethhdr->h_dest,^M$

ERROR: DOS line endings
#174: FILE: routing.c:758:
+^I^I^I^I       old_ttvn, curr_ttvn);^M$

total: 26 errors, 3 warnings, 0 checks, 65 lines checked

[B.A.T.M.A.N.] [PATCH] remove unnecessary logspam.eml has style
problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


maybe it's the mail client that messes the patch up? Are you using
git-send-email ?


Cheers,

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]