Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Init and use batman interface with correc netns.

[Antonio Quartulli <antonio@meshcoding.com>]

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

On 12/06/14 11:48, Marek Lindner wrote:
> On Monday 26 May 2014 12:18:38 Daniel Ehlers wrote:
>> Enables us to use batman-adv inside of network namespaces.
>> Unfortunately it does not enable us to use multiple batX interfaces
>> in different namespaces. This limitation results from using
>> debugfs and its unawareness of namespaces.
>>
>> Signed-off-by: Daniel Ehlers <danielehlers@mindeye.net>
>> ---
>>  hard-interface.c    | 10 ++++++----
>>  hard-interface.h    |  2 +-
>>  soft-interface.c    |  8 ++++++--
>>  soft-interface.h    |  2 +-
>>  sysfs.c             |  4 +++-
>>  translation-table.c |  4 +++-
>>  6 files changed, 20 insertions(+), 10 deletions(-)
> 
> Would you mind re-sending both patches while cc'ing the netdev list and 
> specifically asking for reviews from the namespace people ? None of us has any 
> experience with netns. As such a meaningful review is difficult for us.
> 
> Furthermore, your commit message should be more explicit about what the patch 
> is trying to fix / improve. Things like 'issue #179' are too vague to be 
> understandable by everyone.
> 

Please specify "RFC" instead of "PATCH" in the subject when sending it
to netdev, this way nobody thinks that it was sent for a direct
inclusion (net-next is closed now, so somebody might not be happy).

Cheers,

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]