From: Antonio Quartulli <antonio@meshcoding.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: netdev@vger.kernel.org
Subject: Re: [B.A.T.M.A.N.] Fw: [Bug 84061] New: net/batman-adv/gateway_client.c:813: missing sanity check and dodgy coding ?
Date: Tue, 09 Sep 2014 17:02:52 +0200 [thread overview]
Message-ID: <540F169C.8030700@meshcoding.com> (raw)
In-Reply-To: <20140908173014.2946e411@uryu.home.lan>
[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]
forwarding to the batman-adv mailing list and commenting inline.
On 09/09/14 02:30, Stephen Hemminger wrote:
>
>
> Begin forwarded message:
>
> Date: Mon, 8 Sep 2014 00:04:40 -0700
> From: "bugzilla-daemon@bugzilla.kernel.org" <bugzilla-daemon@bugzilla.kernel.org>
> To: "stephen@networkplumber.org" <stephen@networkplumber.org>
> Subject: [Bug 84061] New: net/batman-adv/gateway_client.c:813: missing sanity check and dodgy coding ?
>
>
> https://bugzilla.kernel.org/show_bug.cgi?id=84061
>
> Bug ID: 84061
> Summary: net/batman-adv/gateway_client.c:813: missing sanity
> check and dodgy coding ?
> Product: Networking
> Version: 2.5
> Kernel Version: 3.17-rc4
> Hardware: All
> OS: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Other
> Assignee: shemminger@linux-foundation.org
> Reporter: dcb314@hotmail.com
> Regression: No
>
> net/batman-adv/gateway_client.c:813:31: warning: logical not is only applied to
> the left hand side of comparison [-Wlogical-not-parentheses]
>
> gw_node = batadv_gw_node_get(bat_priv, orig_dst_node);
> if (!gw_node->bandwidth_down == 0)
> goto out;
I think this was meant to be:
if (!gw_node || (gw_node->bandwidth_down == 0))
>
> Function batadv_gw_node_get can return NULL, so there's
> a missing sanity check there and maybe the if condition
> can be reworked for clarity.
>
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
parent reply other threads:[~2014-09-09 15:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20140908173014.2946e411@uryu.home.lan>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F169C.8030700@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox