From: Antonio Quartulli <antonio@meshcoding.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: "Martin Hundebøll" <martin@hundeboll.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: clear control block of received socket buffers
Date: Wed, 17 Sep 2014 09:17:32 +0200 [thread overview]
Message-ID: <5419358C.4030500@meshcoding.com> (raw)
In-Reply-To: <1410936979-2219-1-git-send-email-martin@hundeboll.net>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
On 17/09/14 08:56, Martin Hundebøll wrote:
> Since other network components (and some drivers) uses the control block
> provided in skb's, the network coding feature might wrongly assume that
> an SKB has been decoded, and thus not try to code it with another packet
> again. This happens for instance when batman-adv is running on a bridge device.
>
> Fix this by clearing the control block for every received SKB.
>
> Introduced-by: 3c12de9a5c756b23fe7c9ab332474ece1568914c ("batman-adv: network coding - code and transmit packets if possible")
maybe the maintainer can split this line before pushing the patch, but
next time split this it in two of them :-) (like other patches we have)
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-17 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 6:56 [B.A.T.M.A.N.] [PATCH maint] batman-adv: clear control block of received socket buffers Martin Hundebøll
2014-09-17 7:17 ` Antonio Quartulli [this message]
2014-11-09 4:57 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5419358C.4030500@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=martin@hundeboll.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox