From: Sven Eckelmann <sven@narfation.org>
To: Andrew Strohman <andrew@andrewstrohman.com>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH] batman-adv: fix panic during interface removal
Date: Thu, 09 Jan 2025 11:23:42 +0100 [thread overview]
Message-ID: <5533653.Sb9uPGUboI@ripper> (raw)
In-Reply-To: <CAA8ajJkhd=CaNoqZ+juKHh8PV975s_vEfLU4xLfwn-Yj+caEPg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Thursday, 9 January 2025 11:10:40 CET Andrew Strohman wrote:
> But this got me thinking about the unlikely scenario where the soft if
> netdevice is
> destroyed before this work is run.
I would prefer when you would call cancel_work_sync when metric stuff should
be stopped. I was expecting to see this somewhere around
batadv_v_elp_iface_disable after the cancel_work_sync but it seems like it is
missing there (or in a similar place)
void batadv_v_elp_iface_disable(struct batadv_hard_iface *hard_iface)
{
cancel_delayed_work_sync(&hard_iface->bat_v.elp_wq);
+ cancel_work_sync(&hard_iface->bat_v.metric_work);
dev_kfree_skb(hard_iface->bat_v.elp_skb);
hard_iface->bat_v.elp_skb = NULL;
}
The Fixes line for this patch would be:
Fixes: 5c3245172c01 ("batman-adv: ELP - compute the metric based on the estimated throughput")
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-01-09 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 2:27 [PATCH] batman-adv: fix panic during interface removal Andy Strohman
2025-01-09 7:46 ` Sven Eckelmann
2025-01-09 10:10 ` Andrew Strohman
2025-01-09 10:23 ` Sven Eckelmann [this message]
2025-01-10 9:02 ` Andrew Strohman
2025-01-10 13:10 ` Remi Pommarel
2025-01-13 7:35 ` Andrew Strohman
2025-01-19 22:28 ` Andrew Strohman
2025-01-19 23:03 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5533653.Sb9uPGUboI@ripper \
--to=sven@narfation.org \
--cc=andrew@andrewstrohman.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox