From: Antonio Quartulli <antonio@meshcoding.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release
Date: Mon, 20 Apr 2015 14:22:28 +0200 [thread overview]
Message-ID: <5534EF84.8090402@meshcoding.com> (raw)
In-Reply-To: <7605822.cxC5KnHP44@bentobox>
[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]
On 20/04/15 14:12, Sven Eckelmann wrote:
> Can you also check the "weird" patch which is in the release since 2014.2.0
> but doesn't seem to be in net-next.git/linux.git?
>
> http://git.open-mesh.org/batman-adv.git/commit/31f391475cc08724e96ab060ef4aa6503d11da8e
Why this patch is not upstream I don't know - it made its way through my
pipe to net-next, but probably was never sent.
However, after re-reading this patch and quickly testing the current
behaviour with linux-4.0 I have some doubts about its usefulness.
The problem I tried to fix with this patch started by observing that
when changing the MAC address of a soft-iface VLAN (e.g. bat0.2)
ndo_set_mac_address() seemed not to be called.
Therefore with this patch I change the no-purge MAC addresses in the
local translation table when the MAC address of bat0 got changed.
I think we would need to investigate a bit more if this is still true or
not and then decide to revert or not this patch (in the latter case I
will send it to net-next).
A test that could be done consists in checking if ndo_set_mac_address()
gets invoked when changing the MAC address of any bat0.x interface.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-04-20 12:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 16:32 [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release Sven Eckelmann
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39 Sven Eckelmann
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 2/6] batman-adv: replace strnicmp with strncasecmp Sven Eckelmann
2015-04-20 3:34 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 3/6] batman-adv: Use kasprintf Sven Eckelmann
2015-04-20 3:37 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 4/6] dev: introduce dev_get_iflink() Sven Eckelmann
2015-04-17 16:40 ` [B.A.T.M.A.N.] [PATCH-nextv2 " Sven Eckelmann
2015-04-17 17:15 ` [B.A.T.M.A.N.] [PATCH-nextv2 4/6] batman-adv: " Sven Eckelmann
2015-04-20 3:38 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 5/6] Revert "batman-adv: fix var name to keep compatibility with old kernels" Sven Eckelmann
2015-04-17 17:18 ` [B.A.T.M.A.N.] [PATCH-nextv2 5/6] batman-adv: Revert "fix " Sven Eckelmann
2015-04-20 14:06 ` Antonio Quartulli
2015-04-20 15:23 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 6/6] batman-adv: Use kernel variable declaration order in batadv_send_skb_unicast Sven Eckelmann
2015-04-20 15:27 ` Marek Lindner
2015-04-20 16:05 ` Sven Eckelmann
2015-04-21 8:16 ` Antonio Quartulli
2015-04-20 3:32 ` [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39 Marek Lindner
2015-04-20 6:11 ` Sven Eckelmann
2015-04-20 6:24 ` Marek Lindner
2015-04-17 18:03 ` [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release Sven Eckelmann
2015-04-20 17:25 ` Sven Eckelmann
2015-04-20 3:23 ` Marek Lindner
2015-04-20 6:05 ` Sven Eckelmann
2015-04-20 6:30 ` Marek Lindner
2015-04-20 12:05 ` Antonio Quartulli
2015-04-20 12:12 ` Sven Eckelmann
2015-04-20 12:22 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5534EF84.8090402@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).