[B.A.T.M.A.N.] [PATCH] batman-adv:Make the function batadv_is_my_mac bool

[B.A.T.M.A.N.] [PATCH] batman-adv:Make the function batadv_is_my_mac bool

[Nicholas Krause]

This makes the function batadv_is_my_mac bool now due
to this particular function only returning either one
or zero as its return value.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 net/batman-adv/main.c | 6 +++---
 net/batman-adv/main.h | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
index 12fc77b..47051d1 100644
--- a/net/batman-adv/main.c
+++ b/net/batman-adv/main.c
@@ -210,7 +210,7 @@ void batadv_mesh_free(struct net_device *soft_iface)
  * @bat_priv: the bat priv with all the soft interface information
  * @addr: the address to check
  */
-int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr)
+bool batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr)
 {
 	const struct batadv_hard_iface *hard_iface;
 
@@ -224,11 +224,11 @@ int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr)
 
 		if (batadv_compare_eth(hard_iface->net_dev->dev_addr, addr)) {
 			rcu_read_unlock();
-			return 1;
+			return true;
 		}
 	}
 	rcu_read_unlock();
-	return 0;
+	return false;
 }
 
 /**
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 4d23188..8f6e256 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -195,7 +195,7 @@ extern struct workqueue_struct *batadv_event_workqueue;
 
 int batadv_mesh_init(struct net_device *soft_iface);
 void batadv_mesh_free(struct net_device *soft_iface);
-int batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr);
+bool batadv_is_my_mac(struct batadv_priv *bat_priv, const uint8_t *addr);
 struct batadv_hard_iface *
 batadv_seq_print_text_primary_if_get(struct seq_file *seq);
 int batadv_max_header_len(void);
-- 
2.1.4

Re: [B.A.T.M.A.N.] [PATCH] batman-adv:Make the function batadv_is_my_mac bool

[Antonio Quartulli]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Nicholas,

On 11/06/15 04:25, Nicholas Krause wrote:
> This makes the function batadv_is_my_mac bool now due
> to this particular function only returning either one
> or zero as its return value.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>

NAK.

we already have ("batman-adv: main, Convert is_my_mac() to bool") in
net-next that does exactly the same. I guess you did not pull the latest
changes before writing this patch?

Cheers,


-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv:Make the function batadv_is_my_mac bool

[Nicholas Krause]

On June 11, 2015 1:53:04 AM EDT, Antonio Quartulli <antonio@meshcoding.com> wrote:
>Nicholas,
>
>On 11/06/15 04:25, Nicholas Krause wrote:
>> This makes the function batadv_is_my_mac bool now due
>> to this particular function only returning either one
>> or zero as its return value.
>> 
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>
>NAK.
>
>we already have ("batman-adv: main, Convert is_my_mac() to bool") in
>net-next that does exactly the same. I guess you did not pull the
>latest
>changes before writing this patch?
>
>Cheers,
I was basing this patch off Linux's tree, 
that's why. 
Nick 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.