From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <558169C5.7050700@meshcoding.com> Date: Wed, 17 Jun 2015 14:36:21 +0200 From: Antonio Quartulli MIME-Version: 1.0 References: <1434542995-22376-1-git-send-email-mareklindner@neomailbox.ch> In-Reply-To: <1434542995-22376-1-git-send-email-mareklindner@neomailbox.ch> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BklpFaR6t24e6QbF15NC8sDk0mHd9J35u" Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: protect tt_local_entry from concurrent delete events Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking Cc: Marek Lindner This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BklpFaR6t24e6QbF15NC8sDk0mHd9J35u Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 17/06/15 14:09, Marek Lindner wrote: > The tt_local_entry deletion performed batadv_tt_local_remove() was neit= her > protecting against simultaneous deletes nor checking whether the elemen= t > was still part of the list before calling hlist_del_rcu(). >=20 > Replacing the hlist_del_rcu() with batadv_hash_remove() provides adequa= te > protection via hash spinlocks as well as a is-element-still-in-hash che= ck. >=20 > Reported-by: alfonsname@web.de > Signed-off-by: Marek Lindner Acked-by: Antonio Quartulli Thanks! --=20 Antonio Quartulli --BklpFaR6t24e6QbF15NC8sDk0mHd9J35u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVgWnIAAoJEOb/4TMchkvf770P/1HzfLEb1izj8Clj8fbNp4G/ 31ttB8R8QzYHPZN9FRVYU3AgYp6f/zbDAzzcLtLtwVromUgbz5NQ3Jji4Pjb6A83 GXMFVUuotIPrzB9W3LdTZkMAcmThTB1dzrl8hD4CZB5NgwMU/VDTchSfOIFwKjZJ YvjzP+ncyUhmKnDlD78rHGwafSxzoeoYajIsUyAxGHcQTeLQtE6qiOHLYKMxOpK5 7HTGaAKesXWr1DH/Fe0+WiH11d6RE5JScLnlb27hw1k1WlzMeBzUIp+PwP39hImw ndowfFCBdTGMYRcA0VMRTVVOSt6MyHUxc/1VyJKvhhV3PXRjukX63s4Jxfm/HXhn 9+MZVJOoPVOyObnGDsxpdfQHjVrgUSFQraF0ov69NGkEMrtEZjWxojS/ivzMGcQB DTpsHRtOBj2pCmyiaO/QboWoP2QvZlzbNSq6u7Oqi1wViw5gF5gVtCyz0pg1Y2pV 4lwF3Jb+3CGDn0ziRmhm/nUtm6oUvIUm9UOWchPHPhFeVFIfkDXil+oFTxeMyVjz ug5KIr8j0PYgjQmRD2YWOvrmIYnK0XgsL6CXnR/VONnbSSCJGMTSui/Q0X0kNMCf TxZNu26/J43WMfYzFeS03ZKG4F8VvQWItHwfJL//bJ8jcAzORlJT3bJZPFPVusPg Gp9hzJaQviqP2PIHOfvV =Hg0N -----END PGP SIGNATURE----- --BklpFaR6t24e6QbF15NC8sDk0mHd9J35u--