From: Antonio Quartulli <antonio@meshcoding.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix kernel crash due to missing NULL checks
Date: Thu, 18 Jun 2015 21:31:21 +0200 [thread overview]
Message-ID: <55831C89.9030707@meshcoding.com> (raw)
In-Reply-To: <1434596669-9597-1-git-send-email-mareklindner@neomailbox.ch>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On 18/06/15 05:04, Marek Lindner wrote:
> diff --git a/translation-table.c b/translation-table.c
> index e95a424..ae82f69 100644
> --- a/translation-table.c
> +++ b/translation-table.c
> @@ -575,6 +575,11 @@ bool batadv_tt_local_add(struct net_device *soft_iface, const uint8_t *addr,
>
> /* increase the refcounter of the related vlan */
> vlan = batadv_softif_vlan_get(bat_priv, vid);
> + if (!vlan) {
> + WARN(1, "adding TT local entry %pM to non-existent VLAN %d",
> + addr, BATADV_PRINT_VID(vid));
WARN returns the value of the expression passed as first argument,
therefore you can directly pass "!vlan" and use the whole macro
invocation as if condition.
Note: if you are going to merge this patch before Sven's one you need to
also include bug.h.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-18 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 3:04 [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix kernel crash due to missing NULL checks Marek Lindner
2015-06-18 19:31 ` Antonio Quartulli [this message]
2015-06-19 5:50 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55831C89.9030707@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox