From: Antonio Quartulli <antonio@meshcoding.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
alessandro@mediaspot.net
Subject: Re: [B.A.T.M.A.N.] [PATCH-maint 1/4] batman-adv: fix speedy join for DAT cache replies
Date: Tue, 25 Aug 2015 11:42:05 +0200 [thread overview]
Message-ID: <55DC386D.70109@meshcoding.com> (raw)
In-Reply-To: <1440170118-10876-2-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On 21/08/15 17:15, Simon Wunderlich wrote:
> + /* Cache replies should not be considered for speedy
> + * join, since the clients do not actually reside at
> + * the originator.
> + */
> + if (subtype != BATADV_P_DAT_CACHE_REPLY) {
Tha patch looks good but this should really be:
if (subtype == BATADV_P_DATA) {
because speedy join is supposed to work with any payload packet.
Cheers,
> + orig_addr = unicast_4addr_packet->src;
> + orig_node = batadv_orig_hash_find(bat_priv,
> + orig_addr);
> + }
> }
>
> if (batadv_dat_snoop_incoming_arp_request(bat_priv, skb,
>
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-25 9:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 15:15 [B.A.T.M.A.N.] [PATCH-maint 0/4] Some fixes for DAT/TT/Speedy join corner cases Simon Wunderlich
2015-08-21 15:15 ` [B.A.T.M.A.N.] [PATCH-maint 1/4] batman-adv: fix speedy join for DAT cache replies Simon Wunderlich
2015-08-25 9:42 ` Antonio Quartulli [this message]
2015-08-25 15:24 ` Simon Wunderlich
2015-08-21 15:15 ` [B.A.T.M.A.N.] [PATCH-maint 2/4] batman-adv: avoid keeping false temporary entry Simon Wunderlich
2015-08-25 9:49 ` Antonio Quartulli
2015-08-25 15:27 ` Simon Wunderlich
2015-08-21 15:15 ` [B.A.T.M.A.N.] [PATCH-maint 3/4] batman-adv: unify flags access style in tt global add Simon Wunderlich
2015-08-25 9:51 ` Antonio Quartulli
2015-08-25 15:28 ` Simon Wunderlich
2015-08-25 16:14 ` Antonio Quartulli
2015-08-21 15:15 ` [B.A.T.M.A.N.] [PATCH-maint 4/4] batman-adv: detect local excess vlans in TT request Simon Wunderlich
2015-08-25 9:59 ` Antonio Quartulli
2015-08-25 15:31 ` Simon Wunderlich
2015-08-25 18:28 ` Antonio Quartulli
2015-08-25 21:12 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC386D.70109@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=alessandro@mediaspot.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox