Re: [B.A.T.M.A.N.] [PATCH-maint 1/4] batman-adv: fix speedy join for DAT cache replies

Antonio Quartulli
2015-08-25T09:42:05Z

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

On 21/08/15 17:15, Simon Wunderlich wrote:
> + /* Cache replies should not be considered for speedy
> + * join, since the clients do not actually reside at
> + * the originator.
> + */
> + if (subtype != BATADV_P_DAT_CACHE_REPLY) {

Tha patch looks good but this should really be:

if (subtype == BATADV_P_DATA) {

because speedy join is supposed to work with any payload packet.

Cheers,

> + orig_addr = unicast_4addr_packet->src;
> + orig_node = batadv_orig_hash_find(bat_priv,
> + orig_addr);
> + }
> }
>
> if (batadv_dat_snoop_incoming_arp_request(bat_priv, skb,
>

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]