From: Antonio Quartulli <antonio@meshcoding.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
alessandro@mediaspot.net
Subject: Re: [B.A.T.M.A.N.] [PATCH-maintv2 2/3] batman-adv: avoid keeping false temporary entry
Date: Tue, 1 Sep 2015 11:00:29 +0200 [thread overview]
Message-ID: <55E5692D.8090909@meshcoding.com> (raw)
In-Reply-To: <1440600113-21305-3-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On 26/08/15 16:41, Simon Wunderlich wrote:
> In the case when a temporary entry is added first and a proper tt entry
> is added after that, the temporary tt entry is kept in the orig list.
> However the temporary flag is removed at this point, and therefore the
> purge function can not find this temporary entry anymore.
When can this really happen? When a temporary client has roamed to a new
originator before it could be claimed by the first one ? Or are there
other cases ? I think it is important to make this clear, because the
original logic was such as the expected behaviour was to receive an ADD
event from the same originator where the temporary client was seen.
Other than this, the patch looks good.
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-01 9:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 14:41 [B.A.T.M.A.N.] [PATCH-maintv2 0/3] Some fixes for DAT/TT/Speedy join corner cases Simon Wunderlich
2015-08-26 14:41 ` [B.A.T.M.A.N.] [PATCH-maintv2 1/3] batman-adv: fix speedy join for DAT cache replies Simon Wunderlich
2015-08-31 16:36 ` Antonio Quartulli
2015-08-26 14:41 ` [B.A.T.M.A.N.] [PATCH-maintv2 2/3] batman-adv: avoid keeping false temporary entry Simon Wunderlich
2015-09-01 9:00 ` Antonio Quartulli [this message]
2015-09-01 11:00 ` Simon Wunderlich
2015-09-01 11:30 ` Antonio Quartulli
2015-09-02 17:35 ` Simon Wunderlich
2015-08-26 14:41 ` [B.A.T.M.A.N.] [PATCH-maintv2 3/3] batman-adv: detect local excess vlans in TT request Simon Wunderlich
2015-09-01 10:07 ` Antonio Quartulli
2015-09-02 17:39 ` Simon Wunderlich
2015-09-02 17:57 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5692D.8090909@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=alessandro@mediaspot.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox