Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

Sven Eckelmann
2016-05-31T17:57:37Z

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On Friday 11 March 2016 13:40:56 SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 11 Mar 2016 13:10:20 +0100
>
> The variables "tt_local_entry" and "tt_global_entry" were eventually
> checked again despite of a corresponding null pointer test before.
>
> * Avoid this double check by reordering a function call sequence
> and the better selection of jump targets.
>
> * Omit the initialisation for these variables at the beginning then.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---

Reviewed-by: Sven Eckelmann <sven@narfation.org>

See

* https://www.kernel.org/doc/Documentation/SubmittingPatches
Chapter 7: Centralized exiting of functions
* https://plus.google.com/106378716002406849458/posts/dnanfhQ4mHQ
* http://article.gmane.org/gmane.linux.documentation/28552

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]