From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Annika Wickert <annika.wickert@exaring.de>
Subject: Re: [PATCH 1/2] batman-adv: Prepare infrastructure for newlink settings
Date: Sun, 11 Oct 2020 11:48:41 +0200 [thread overview]
Message-ID: <5766158.W2Ztyaally@sven-edge> (raw)
In-Reply-To: <20201011093909.297580-1-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
Hi,
just noticed a build problem with some older kernels.
On Sunday, 11 October 2020 11:39:08 CEST Sven Eckelmann wrote:
> +#define batadv_softif_validate(__tb, __data, __extack) \
> + batadv_softif_validate(__tb, __data)
> +
> +#define batadv_softif_newlink(__src_net, __dev, __tb, __data, __extack) \
> + batadv_softif_newlink(__src_net, __dev, __tb, __data)
> +
Seems like the compat code has to be changed slightly because the __extack was
not introduced at the same time for all callbacks. These both must not be
handled in the compat code for 4.13 and newer.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-10-11 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 9:39 [PATCH 1/2] batman-adv: Prepare infrastructure for newlink settings Sven Eckelmann
2020-10-11 9:39 ` [PATCH 2/2] batman-adv: Allow selection of routing algorithm over rtnetlink Sven Eckelmann
2020-10-11 9:48 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5766158.W2Ztyaally@sven-edge \
--to=sven@narfation.org \
--cc=annika.wickert@exaring.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox