public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix invalid read while copying bat_iv.bcast_own
Date: Wed, 30 Dec 2015 19:36:26 +0800	[thread overview]
Message-ID: <6284608.dq66nB2XcN@voltaire> (raw)
In-Reply-To: <1448758137-21202-1-git-send-email-sven@narfation.org>

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

On Sunday, November 29, 2015 01:48:57 Sven Eckelmann wrote:
> batadv_iv_ogm_orig_del_if removes a part of the bcast_own which previously
> belonged to the now removed interface. This is done by copying all data
> which comes before the removed interface and then appending all the data
> which comes after the removed interface.
> 
> The address calculation for the position of the data which comes after the
> removed interface assumed that the bat_iv.bcast_own is a pointer to a
> single byte datatype. But it is a pointer to unsigned long and thus the
> calculated position was wrong off factor sizeof(unsigned long).
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  net/batman-adv/bat_iv_ogm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied in revision 24b1aae.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-12-30 11:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-29  0:48 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix invalid read while copying bat_iv.bcast_own Sven Eckelmann
2015-12-30 11:36 ` Marek Lindner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-01-07  7:26 [B.A.T.M.A.N.] pull request [net]: 20160107 Antonio Quartulli
2016-01-07  7:26 ` [B.A.T.M.A.N.] [PATCH] batman-adv: Fix invalid read while copying bat_iv.bcast_own Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6284608.dq66nB2XcN@voltaire \
    --to=mareklindner@neomailbox.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox