Re: [B.A.T.M.A.N.] [PATCH] batctl: Validate translated mac addresses

Sven Eckelmann
2018-04-17T08:35:15Z

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On Freitag, 13. April 2018 20:16:18 CEST Sven Eckelmann wrote:
> The IP translation layer is using the neighbor table of the kernel to get
> the unicast link layer (mac) address for IP(v4|v6) addresses. The kernel
> can not only return unicast mac addresses to such an RTM_GETNEIGH request
> but also zero mac address. Such an address must be considered invalid
> because the global translation table may not only contain a unique client
> mac address entry for it. The translation from client mac to originator
> will therefore most likely return an unexpected originator.
>
> Dropping these kind of (bogus) results avoids confusions while using things
> like batctl's ping or traceroute.
>
> Reported-by: Andre Kasper <Andre.Kasper@gmx.de>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> Cc: Andre Kasper <Andre.Kasper@gmx.de>
>
> See https://www.open-mesh.org/issues/353

Applied in 9f22e3d0ed2a [1]. But the ticket is not marked as resolved but it
seems like the reporter wants a different behavior.

Kind regards,
Sven

[1] https://git.open-mesh.org/batctl.git/commit/9f22e3d0ed2a3d83479f3db3b570f49218024249

[-- Attachment #2: This is a digitally signed message part. --]