Re: [B.A.T.M.A.N.] [PATCH v2 00/26] batman-adv: Cleanups

Markus Pargmann
2015-03-24T11:41:07Z

[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]

Hi Sven,

On Sun, Mar 22, 2015 at 02:34:33AM +0100, Sven Eckelmann wrote:
> On Sunday 22 March 2015 01:52:40 Sven Eckelmann wrote:
> > On Friday 26 December 2014 12:41:17 Markus Pargmann wrote:
> > > Markus Pargmann (26):
> > [...]
> >
> > > batman-adv: packet.h, add some missing includes
> > > batman-adv: types.h, add missing include
> >
> > Just went through the includes and noticed that a lot more are missing (also
> > in the files which you are already touched). I have attached the current
> > state of my analysis so you can compare it with your notes.

Do you have any tool which makes this include analysis easier?

>
> Small disclaimer I forgot:
>
> The patch is currently not finished. Following things are missing:
>
> * #include "types.h" in main.h after "compat.h" (may be removed in the future
> when I can drop it somehow... but it will most likely be added again even
> when there is a dependency circle with types.h)

I hope that types.h can be split up into appropriate topic headers
which are selectively included by the files which need it. However I
didn't have a deeper look into this yet so it may be more complicated.

> * tests with older kernels

I will test your series with an arm build, but I don't think that
anything breaks there.

Best Regards,

Markus

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]