From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv14 3/4] batman-adv: Adding logging of mcast flag changes
Date: Fri, 06 May 2016 01:38:57 +0800 [thread overview]
Message-ID: <6956681.0eiG27MfpC@voltaire> (raw)
In-Reply-To: <1462464426-13014-4-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]
On Thursday, May 05, 2016 17:07:04 Linus Lüssing wrote:
> + querier4.exists = br_multicast_has_querier_anywhere(dev, ETH_P_IP);
> + querier4.shadowing = br_multicast_has_querier_adjacent(dev,
> ETH_P_IP); +
> + querier6.exists = br_multicast_has_querier_anywhere(dev,
> ETH_P_IPV6); + querier6.shadowing =
> br_multicast_has_querier_adjacent(dev, ETH_P_IPV6); +
> mcast_data.flags |= BATADV_MCAST_WANT_ALL_UNSNOOPABLES;
>
> /* 1) If no querier exists at all, then multicast listeners on
> @@ -369,17 +494,26 @@ static bool batadv_mcast_mla_tvlv_update(struct
> batadv_priv *bat_priv) * In both cases, we will signalize other batman
> nodes that * we need all multicast traffic of the according protocol. */
> - if (!br_multicast_has_querier_anywhere(dev, ETH_P_IP) ||
> - br_multicast_has_querier_adjacent(dev, ETH_P_IP))
> + if (!querier4.exists || querier4.shadowing)
> mcast_data.flags |= BATADV_MCAST_WANT_ALL_IPV4;
>
> - if (!br_multicast_has_querier_anywhere(dev, ETH_P_IPV6) ||
> - br_multicast_has_querier_adjacent(dev, ETH_P_IPV6))
> + if (!querier6.exists || querier6.shadowing)
> mcast_data.flags |= BATADV_MCAST_WANT_ALL_IPV6;
Please move these variable assignments into your previous patch that
introduces this section.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-05 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 16:07 [B.A.T.M.A.N.] [PATCHv14 0/4] Multicast optimizations for bridges Linus Lüssing
2016-05-05 16:07 ` [B.A.T.M.A.N.] [PATCHv14 1/4] batman-adv: Always flood IGMP/MLD reports Linus Lüssing
2016-05-08 13:50 ` Marek Lindner
2016-05-05 16:07 ` [B.A.T.M.A.N.] [PATCHv14 2/4] batman-adv: Add multicast optimization support for bridged setups Linus Lüssing
2016-05-05 16:07 ` [B.A.T.M.A.N.] [PATCHv14 3/4] batman-adv: Adding logging of mcast flag changes Linus Lüssing
2016-05-05 17:38 ` Marek Lindner [this message]
2016-05-05 16:07 ` [B.A.T.M.A.N.] [PATCHv14 4/4] batman-adv: Add debugfs table for mcast flags Linus Lüssing
2016-05-05 17:38 ` Marek Lindner
2016-05-05 21:15 ` [B.A.T.M.A.N.] [PATCHv14 0/4] Multicast optimizations for bridges Sven Eckelmann
2016-05-10 0:03 ` Linus Lüssing
2016-05-10 0:16 ` Linus Lüssing
2016-05-10 0:30 ` Linus Lüssing
2016-05-10 7:43 ` Sven Eckelmann
2016-05-10 9:11 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6956681.0eiG27MfpC@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox