From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Avoid bool in structures
Date: Wed, 25 Apr 2018 19:23:21 +0200 [thread overview]
Message-ID: <6964695.auRBVytUBx@sven-edge> (raw)
In-Reply-To: <20180419190108.11396-1-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
On Donnerstag, 19. April 2018 21:01:07 CEST Sven Eckelmann wrote:
> Using the bool type for structure member is considered inappropriate [1]
> for the kernel. Its size is not well defined (but usually 1 byte but maybe
> also 4 byte).
>
> [1] https://lkml.org/lkml/2017/11/21/384
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> net/batman-adv/types.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Both patches added as b8f25ee5d426 [1] and 566b52be5f23 [2]
Kind regards,
Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/b8f25ee5d4263d4eab3a66cae338037f1645c427
[2] https://git.open-mesh.org/batman-adv.git/commit/566b52be5f23eb5ffe94dd40f956c9a473129251
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-25 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 19:01 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Avoid bool in structures Sven Eckelmann
2018-04-19 19:01 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Remove unused dentry without DEBUGFS Sven Eckelmann
2018-04-25 17:23 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6964695.auRBVytUBx@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox