From: yajun.deng@linux.dev
To: Antonio Quartulli <a@unstable.cc>,
mareklindner@neomailbox.ch, sw@simonwunderlich.de,
sven@narfation.org
Cc: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] batman-adv: Fix the wrong definition
Date: Thu, 28 Oct 2021 07:49:15 +0000 [thread overview]
Message-ID: <6da1057ad867699815cef87cb2a79057@linux.dev> (raw)
In-Reply-To: <da6fa493-0911-ca3f-16c0-380bc35d8317@unstable.cc>
October 28, 2021 3:35 PM, "Antonio Quartulli" <a@unstable.cc> 写到:
> Hi,
>
> On 28/10/2021 09:23, Yajun Deng wrote:
>
>> There are three variables that are required at most,
>> no need to define four variables.
>>
>> Fixes: 0fa4c30d710d ("batman-adv: Make sysfs support optional")
>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>
> NAK.
>
> kobject_uevent_env() does not know how many items are stored in the
> array and thus requires it to be NULL terminated.
>
> Please check the following for reference:
>
> https://elixir.bootlin.com/linux/v5.15-rc6/source/lib/kobject_uevent.c#L548
>
Oh, I didn't notice there.
> OTOH I guess we could still use '{}' for the initialization.
>
> Regards,
>
> --
> Antonio Quartulli
prev parent reply other threads:[~2021-10-28 7:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 7:23 [PATCH net-next] batman-adv: Fix the wrong definition Yajun Deng
2021-10-28 7:34 ` Sven Eckelmann
2021-10-28 7:35 ` Antonio Quartulli
2021-10-28 7:49 ` yajun.deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da1057ad867699815cef87cb2a79057@linux.dev \
--to=yajun.deng@linux.dev \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).