public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Update/repair bridge loop avoidance kerneldoc
Date: Thu, 05 Nov 2015 20:25:51 +0100	[thread overview]
Message-ID: <7310581.ItoMCAyTIj@sven-edge> (raw)
In-Reply-To: <1446750782-30179-1-git-send-email-sw@simonwunderlich.de>

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Hi,

thanks for the massive update of the kernel function documentation of the 
bridge loop avoidance code.

On Thursday 05 November 2015 20:13:02 Simon Wunderlich wrote:
> Thanks to Sven for starting this and making initial changes.

I don't think this should be in the commit message 

> -/* initialize all bla structures */
> +/**
> + * batadv_bla_init - initialize all bla structures
> + * @bat_priv: the bat priv with all the soft interface information
> + */
>  int batadv_bla_init(struct batadv_priv *bat_priv)

kernel-doc doesn't like that the return value documentation is missing here:

    No description found for return value of 'batadv_bla_init'


Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-11-05 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 19:13 [B.A.T.M.A.N.] [PATCH] batman-adv: Update/repair bridge loop avoidance kerneldoc Simon Wunderlich
2015-11-05 19:25 ` Sven Eckelmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-06  9:45 Simon Wunderlich
2015-11-06  9:54 ` Simon Wunderlich
2015-11-17  7:36 ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7310581.ItoMCAyTIj@sven-edge \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=sw@simonwunderlich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox