Re: [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

On Monday 20 April 2015 11:32:23 Marek Lindner wrote:
> On Friday, April 17, 2015 18:34:16 Sven Eckelmann wrote:
> > From: Marek Lindner <mareklindner@neomailbox.ch>
> > 
> > batman-adv calls netdev_master_upper_dev_link() which is replaced with
> > with
> > netdev_set_master() for kernels older than 3.9 via compat.h.
> > Prior to 2.6.39 netdev_set_master() contained Linux bonding calls needed
> > to
> > setup bonding devices. Calling this function from batman-adv leads to
> > unexpected behavior when current batman-adv versions are used on these
> > older kernels.
> > 
> > To fix the situation compat.h now ships its own implementation of
> > netdev_set_master() which does not change the net_dev->master state
> > on kernels older than 2.6.39.
> > 
> > Reported-by: Andreas Pape <APape@phoenixcontact.com>
> > Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
> > Signed-off-by: Sven Eckelmann <sven@narfation.org>
> > ---
> > 
> >  compat.h | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> 
> I have already cherry-picked that patch myself.

Depends on your definition of "already". It was not cherry-picked when I've 
sent this patch. The commit you are referring to was cherry-picked 25 minutes 
before you wrote this mail and my patch was send 5160 minutes before your 
mail.

Kind regard,s
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]