* [B.A.T.M.A.N.] [PATCH next] batman-adv: no need for return in void functions
@ 2013-09-22 18:26 Antonio Quartulli
2013-09-24 12:25 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Quartulli @ 2013-09-22 18:26 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
Only network-coding.h is using "return;" inside void stub
functions. This is not a consistent with the rest of the code,
therefore don't continue to do as such.
(Other stub functions will be cleaned later)
Introduced by 7dd9d8992b0c197ba656a6d9a70966cea10fc2d9
("batman-adv: tvlv - add network coding container")
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
network-coding.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/network-coding.h b/network-coding.h
index 8a97b40..d2f110c 100644
--- a/network-coding.h
+++ b/network-coding.h
@@ -49,7 +49,6 @@ int batadv_nc_init_debugfs(struct batadv_priv *bat_priv);
static inline void batadv_nc_status_update(struct net_device *net_dev)
{
- return;
}
static inline int batadv_nc_init(struct batadv_priv *bat_priv)
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [B.A.T.M.A.N.] [PATCH next] batman-adv: no need for return in void functions
2013-09-22 18:26 [B.A.T.M.A.N.] [PATCH next] batman-adv: no need for return in void functions Antonio Quartulli
@ 2013-09-24 12:25 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2013-09-24 12:25 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Antonio Quartulli
On Sunday 22 September 2013 20:26:50 Antonio Quartulli wrote:
> Only network-coding.h is using "return;" inside void stub
> functions. This is not a consistent with the rest of the code,
> therefore don't continue to do as such.
> (Other stub functions will be cleaned later)
>
> Introduced by 7dd9d8992b0c197ba656a6d9a70966cea10fc2d9
> ("batman-adv: tvlv - add network coding container")
>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
> network-coding.h | 1 -
> 1 file changed, 1 deletion(-)
Applied in revision 96cebef.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-24 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-22 18:26 [B.A.T.M.A.N.] [PATCH next] batman-adv: no need for return in void functions Antonio Quartulli
2013-09-24 12:25 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox