Re: [B.A.T.M.A.N.] [PATCH] batctl: add switch for setting multicast_fanout

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]

On Thursday, 14 February 2019 13.54.15 CET Linus Lüssing wrote:
> This patch adds an option for the new multicast_fanout setting in
> batman-adv.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  Makefile           |   1 +
>  README.rst         |  10 +++++
>  batman_adv.h       |   7 ++++
>  man/batctl.8       |   5 +++
>  multicast_fanout.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 138 insertions(+)
>  create mode 100644 multicast_fanout.c

change in event.c is missing to parse the mcast "config" group messages with 
BATADV_ATTR_MULTICAST_FANOUT.

BATADV_ATTR_MULTICAST_FANOUT was not added to netlink.c's 
batadv_netlink_policy

> diff --git a/Makefile b/Makefile
> index 4d8b709..15bc3ec 100755
> --- a/Makefile
> +++ b/Makefile
> @@ -69,6 +69,7 @@ $(eval $(call add_command,log,y))
>  $(eval $(call add_command,loglevel,y))
>  $(eval $(call add_command,mcast_flags,y))
>  $(eval $(call add_command,multicast_mode,y))
> +$(eval $(call add_command,multicast_fanout,y))
>  $(eval $(call add_command,nc_nodes,y))
>  $(eval $(call add_command,neighbors,y))
>  $(eval $(call add_command,network_coding,y))

multicast_fanout comes before multicast_mode (alphabetical order)

> diff --git a/README.rst b/README.rst
> index 4c0f544..a3a61ac 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -478,6 +478,16 @@ Usage::
>    batctl multicast_mode|mm [0|1]
>  
>  
> +batctl multicast_fanout
> +=====================
> +
> +display or modify the multicast fanout setting
[...]

This is not valid restructuredtext:

    $ rst2html README.rst > /dev/null
    README.rst:482: (WARNING/2) Title underline too short.
    
    batctl multicast_fanout
    =====================
    README.rst:482: (WARNING/2) Title underline too short.
    
    batctl multicast_fanout
    =====================

[...]
> +static struct settings_data batctl_settings_multicast_fanout = {
> +	.sysfs_name = "multicast_fanout",

There should be no sysfs_name for this (see discussion in batman-adv patch).

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]