Re: [B.A.T.M.A.N.] [PATCHv7 0/3] Multicast optimizations for bridges

[Simon Wunderlich <sw@simonwunderlich.de>]

On Friday 08 August 2014 04:46:26 Linus Lüssing wrote:
> This patchset enables the usage of the batman-adv multicast optimizations
> for scenarios involving bridges on top of e.g. bat0, too.
> 
> Along come two more patches adding according debugging facilities
> to make it possible for the user to check why the multicast
> optimizations might not work ideally to give hints about
> what they might change about their topology.
> 
> Cheers, Linus

As discussed in private, here are some things which I've noticed during my 
tests which should get fixed:

 * With batctl mf, in the own flag section, it reports "no querier present +" 
when there is actually a querier present, and "no querier present -" if there 
is no querier -> reversed logic?
 * As a beautification suggestion, you could use the flag names (U/4/6) instead 
of "+" and "." instead of "-" in the batctl mf output to make the connection 
to the reported flags more clear
 * I didn't get any log output (from batctl log) when a querier was shadowed, 
even if batctl mf was showing that correctly. All what was reported was 
IGMP/MLD querier appearing or disappearing. We've discussed that this might be 
due to some delay in the bridge code to report that ...

In general, the tests went fine, if you can resolve these quirks then we can 
add my Reviewed/Tested by, I guess. :)

Thanks!
    Simon