Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix soft-interface MTU computation

Antonio Quartulli
2014-01-21T19:00:31Z

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

On 21/01/14 19:43, Russell Senior wrote:
>>>>>> "Antonio" == Antonio Quartulli <antonio@meshcoding.com> writes:
>
> Antonio> The current MTU computation always returns a value smaller
> Antonio> than 1500bytes even if the real interfaces have an MTU large
> Antonio> enough to compensate the batman-adv overhead.
>
> Antonio> Fix the computation by properly returning the highest
> Antonio> admitted value.
>
> Antonio> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com> ---
>
> This seems to fix the bat0-MTU-unnecessarily-small problem I observed
> last night and reported on the IRC channel. I haven't actually passed
> any traffic over it yet, but the interface is up with the expected MTU
> value with the patch.

Just to be sure the fix is not introducing any misbehaviour: have you
tried setting smaller MTUs to your hard interface? In that case have you
seen the bat0 reducing its MTU?

>
> Antonio> This patch is missing a Reported-by clause because I did not
> Antonio> have "russell"'s email address at hand.
>
> Antonio> Will be added later before being merged.
>
> Reported-by: Russell Senior <russell@personaltelco.net>

I'd also add Tested-by ;)

Thanks a lot!

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]