From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unnecessary check for orig_ifinfo == NULL
Date: Mon, 09 Mar 2015 08:31:11 +0800 [thread overview]
Message-ID: <9025446.ZzMPtjaoT0@voltaire> (raw)
In-Reply-To: <1425225386-19712-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On Sunday, March 01, 2015 16:56:26 Sven Eckelmann wrote:
> orig_ifinfo is dereferenced multiple times in batadv_iv_ogm_update_seqnos
> before the check for NULL is done. The function also exists at the beginning
> when orig_ifinfo would have been NULL. This makes the check at the end
> unnecessary and only confuses the reader/code analyzers.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> bat_iv_ogm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied in revision 8435e41.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-09 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 15:56 [B.A.T.M.A.N.] [PATCH] batman-adv: Remove unnecessary check for orig_ifinfo == NULL Sven Eckelmann
2015-03-09 0:31 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9025446.ZzMPtjaoT0@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox