From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification
Date: Wed, 19 Oct 2016 08:31:03 +0200 [thread overview]
Message-ID: <9062705.AOdrQGRa4W@bentobox> (raw)
In-Reply-To: <20161018232239.GI6366@otheros>
[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]
On Mittwoch, 19. Oktober 2016 01:22:39 CEST Linus Lüssing wrote:
> On Tue, Oct 18, 2016 at 11:28:23PM +0200, Sven Eckelmann wrote:
> > Doesn't seem to scale. Especially when we think about batadv_netlink_ops
> > which should also be const. It is currently not const because of the
> > Linux <= 3.13 workaround.
>
> Hm, okay, batadv_netlink_ops is a little more tricky/larger, yes.
> What about a memcpy'ing approach with BUILD_BUG_ON()'s as
> safe-guards like this:
Yes, this would also be an idea. But I would personally just use the
coccinelle approach because it needs less extra hacks. Or do you have any
problems with coccinelle? My personal preferences are (at the moment):
1. code which doesn't need compat code
2. code which can supported with clean (not too hacky) compat-include
3. code which can be supported with coccinelle
4. code which can be supported with compat.h hacks
5. code which can be supported with small patches
The replace.sh was just a quick way to make sure we can ship 2016.4 without to
many extra modifications.
Btw. this is right now only something for later. It is more important to get
your other changes in master. And also to get the patchwork queue smaller - so
reviews are more than welcome.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-10-19 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 21:21 [B.A.T.M.A.N.] [PATCH] batman-adv: compat: Substitute compat code for netlink constification Linus Lüssing
2016-10-18 21:24 ` Linus Lüssing
2016-10-18 21:28 ` Sven Eckelmann
2016-10-18 23:22 ` Linus Lüssing
2016-10-19 6:31 ` Sven Eckelmann [this message]
2016-10-20 18:33 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9062705.AOdrQGRa4W@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox