From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: deselect current GW on client mode switch off
Date: Sun, 27 Oct 2013 17:46:13 +0800 [thread overview]
Message-ID: <92195114.hafFiLUq8s@diderot> (raw)
In-Reply-To: <1382774343-3316-1-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Saturday 26 October 2013 09:59:03 Antonio Quartulli wrote:
> diff --git a/gateway_client.c b/gateway_client.c
> index 2449afa..2903bdb 100644
> --- a/gateway_client.c
> +++ b/gateway_client.c
> @@ -207,6 +207,10 @@ void batadv_gw_check_client_stop(struct batadv_priv
> *bat_priv) if (!curr_gw)
> return;
>
> + /* deselect the current gateway so that next time that client mode is
> + * enabled a proper GW_ADD event can be sent */
> + batadv_gw_select(bat_priv, NULL);
> +
> /* if batman-adv is switching the gw client mode off and a gateway was
> * already selected, send a DEL uevent
> */
Right above the batadv_gw_check_client_stop() call in batadv_store_gw_mode() a
very similar function is called: batadv_gw_deselect().
Calling batadv_gw_deselect() is not enough to ensure an ADD event is sent ? In
case the old gateway == new gateway we have no event ? If so, that should be
documented somehwere ..
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-10-27 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 7:59 [B.A.T.M.A.N.] [PATCH] batman-adv: deselect current GW on client mode switch off Antonio Quartulli
2013-10-27 9:46 ` Marek Lindner [this message]
2013-10-27 9:53 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92195114.hafFiLUq8s@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox