From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: a@unstable.cc
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs
Date: Wed, 04 May 2016 04:16:23 +0800 [thread overview]
Message-ID: <9583103.SiJDGOReDv@voltaire> (raw)
In-Reply-To: <20160503122046.GK16990@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
On Tuesday, May 03, 2016 14:20:46 Andrew Lunn wrote:
> On Tue, May 03, 2016 at 09:07:35AM +0200, Sven Eckelmann wrote:
> > [...]
> >
> > > +ifeq ($(origin LIBNL_GENL_CFLAGS) $(origin LIBNL_GENL_LDLIBS),
> > > undefined undefined) + LIBNL_GENL_NAME ?= libnl-genl-3.0
> > > + ifeq ($(shell $(PKG_CONFIG) --modversion $(LIBNL_GENL_NAME)
> > > 2>/dev/null),) + $(error No $(LIBNL_GENL_NAME) development libraries
> > > found!)
> > > + endif
> > > + LIBNL_GENL_CFLAGS += $(shell $(PKG_CONFIG) --cflags
> > > $(LIBNL_GENL_NAME))
> > > + LIBNL_GENL_LDLIBS += $(shell $(PKG_CONFIG) --libs $(LIBNL_GENL_NAME))
> > > +endif
> > > +CFLAGS += $(LIBNL_GENL_CFLAGS)
> > > +LDLIBS += $(LIBNL_GENL_LDLIBS)
> >
> >
> >
> > @Simon, @Matthias, @Antonio, @Marek: Should the header file be included in
> > batctl like nl80211.h in iw. Or should we always require the current
> > kernel
> > header files installed to build batctl?
>
> Once the code is mostly complete and stable, i think a local copy
> would be good. It does seems to be the common way.
A local copy sounds like a sensible choice and common practice.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-03 20:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 20:56 [B.A.T.M.A.N.] [PATCHv2] batctl: Use netlink to replace some of debugfs Andrew Lunn
2016-05-03 7:07 ` Sven Eckelmann
2016-05-03 12:20 ` Andrew Lunn
2016-05-03 12:26 ` Sven Eckelmann
2016-05-03 12:47 ` Andrew Lunn
2016-05-03 12:54 ` Sven Eckelmann
2016-05-03 13:08 ` Andrew Lunn
2016-05-03 20:16 ` Marek Lindner [this message]
2016-05-03 20:30 ` Andrew Lunn
2016-05-03 9:47 ` Sven Eckelmann
2016-05-03 9:51 ` Sven Eckelmann
2016-05-03 10:30 ` Sven Eckelmann
2016-05-03 12:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9583103.SiJDGOReDv@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox