Re: [B.A.T.M.A.N.] [PATCH] batman-adv: ELP - use new ethtool_link_get_ksettings API

Andreas Pape
2016-03-14T11:54:36Z

Hi everybody,

"B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org> schrieb am
29.02.2016 03:23:42:

> Von: Marek Lindner <mareklindner@neomailbox.ch>
> An: b.a.t.m.a.n@lists.open-mesh.org
> Kopie: Antonio Quartulli <a@unstable.cc>
> Datum: 29.02.2016 03:24
> Betreff: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: ELP - use new
> ethtool_link_get_ksettings API
> Gesendet von: "B.A.T.M.A.N" <b.a.t.m.a.n-bounces@lists.open-mesh.org>
>
> On Sunday, February 28, 2016 10:44:30 Sven Eckelmann wrote:
> > From: Antonio Quartulli <a@unstable.cc>
> >
> > The ethtool API is changing in linux-4.6 and the B.A.T.M.A.N. V
> > code has to be changed accordingly.
> >
> > Fixes: 5c3245172c01 ("batman-adv: ELP - compute the metric based on
the
> > estimated throughput") Signed-off-by: Antonio Quartulli
<a@unstable.cc>
> > [sven@narfation.org: Added compat code for
__ethtool_get_link_ksettings]
> > Signed-off-by: Sven Eckelmann <sven@narfation.org>
> > ---
> > resend of "RFC v2" as patch with my Signed-off-by added
> >
> > compat-include/linux/ethtool.h | 62
> > ++++++++++++++++++++++++++++++++++++++++++ net/batman-adv/bat_v_elp.c
|
> > 12 ++++----
> > 2 files changed, 68 insertions(+), 6 deletions(-)
> > create mode 100644 compat-include/linux/ethtool.h
>
> Applied in revision 3515604.
>
> Thanks,
> Marek

This patch breaks compatibility with older kernels (2.6.32 in my case ;-).

Is this intended? If I try to compile this I get

..../compat-include/linux/ethtool.h:49: error: implicit declaration of
function '__ethtool_get_settings'

I stumbled across this when I tried to update and test my patches for dat
and bla due to the feedback I received after I updated the master branch.

Kind regards,
Andreas

..................................................................
PHOENIX CONTACT ELECTRONICS GmbH

Sitz der Gesellschaft / registered office of the company: 31812 Bad Pyrmont
USt-Id-Nr.: DE811742156
Amtsgericht Hannover HRB 100528 / district court Hannover HRB 100528
Geschäftsführer / Executive Board: Roland Bent, Dr. Martin Heubeck
___________________________________________________________________
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren, jegliche anderweitige Verwendung sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
----------------------------------------------------------------------------------------------------
This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden.
___________________________________________________________________