B.A.T.M.A.N Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Marek Lindner <marek.lindner@mailbox.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org,
	"René Treffer" <treffer@measite.de>,
	"Andrew Strohman" <andrew@andrewstrohman.com>
Subject: Re: [PATCH RFC] batman-adv: BATMAN V: use/prefer 11s airtime link metric
Date: Sun, 19 Jan 2025 06:05:45 +0100	[thread overview]
Message-ID: <Z4yIKYsFvLyGpmjt@sellars> (raw)
In-Reply-To: <6131569.pqZb4hCDXM@rousseau>

On Sat, Jan 18, 2025 at 05:59:56AM +0100, Marek Lindner wrote:
> FYI, expected throughput and also 802.11 throughput estimation are taking 
> congestion into account.

Are they? At least in minstrel_ht_get_tp_avg() I don't see it:
https://elixir.bootlin.com/linux/v6.12.6/source/net/mac80211/rc80211_minstrel_ht.c#L500

And minstrel_ht_get_expected_throughput() uses
minstrel_ht_get_tp_avg():
https://elixir.bootlin.com/linux/v6.12.6/source/net/mac80211/rc80211_minstrel_ht.c#L1987

Seems to me like it uses the transmission duration of the chosen
WLAN bitrate, multiplies it with the average transmission success
probability on this rate there. And then also factors in aggregation and
cuts off the thing between 10%-90% of chosen rate.

(Also, for a rate control algorithm I think factoring in congestion
would only make sense if the RC algo were also factoring in the size
of the packet to transmit? That is smaller packets have a higher
tolerance to channel congestion. But in the debgufs rc_stats table
I don't see any column per packet size (ranges) either.
I think Minstrel assumes that congestion does not make a difference for
which rate to choose for the sake of simplicity?)

  parent reply	other threads:[~2025-01-19  5:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-18  0:35 [PATCH RFC] batman-adv: BATMAN V: use/prefer 11s airtime link metric Linus Lüssing
2025-01-18  2:00 ` Andrew Strohman
2025-01-18  4:59   ` Marek Lindner
2025-01-19  3:20     ` Andrew Strohman
2025-01-19  3:48       ` Marek Lindner
2025-01-19  4:28       ` Linus Lüssing
2025-01-19  5:05     ` Linus Lüssing [this message]
2025-01-19  5:15       ` Linus Lüssing
2025-01-18  5:08 ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4yIKYsFvLyGpmjt@sellars \
    --to=linus.luessing@c0d3.blue \
    --cc=andrew@andrewstrohman.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=marek.lindner@mailbox.org \
    --cc=treffer@measite.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox