From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH batadv] batman-adv: dat: initialize orig_node of unfilled candidate slots
Date: Tue, 6 Oct 2026 13:04:08 +0200 [thread overview]
Message-ID: <asTVqLO0EWAVM_IE@sellars> (raw)
In-Reply-To: <20261004-dat-eligable-uninitialized-v1-1-9674029343da@narfation.org>
On Sun, Oct 04, 2026 at 10:10:06AM +0200, Sven Eckelmann wrote:
> batadv_dat_select_candidates() allocates the candidate array without
> zeroing it. batadv_choose_next_candidate() marks each slot as
> BATADV_DAT_CANDIDATE_NOT_FOUND but only sets orig_node when an eligible
> originator was found. In the following rounds,
> batadv_is_orig_node_eligible() compares res[j].orig_node of all previous
> slots against the evaluated originator. For slots without candidates, it
> reads uninitialized memory.
>
> The orig_node has to be cleared together with the
> BATADV_DAT_CANDIDATE_NOT_FOUND type.
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
(Though this issue seems very hard/unlikely to trigger? And even
then the consequences would be minor and temporary?)
(Also, I can't read the Sashiko link, I guess it's only accessible for
maintainers?)
next prev parent reply other threads:[~2026-10-06 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 8:10 [PATCH batadv] batman-adv: dat: initialize orig_node of unfilled candidate slots Sven Eckelmann
2026-10-06 11:04 ` Linus Lüssing [this message]
2026-10-06 16:57 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asTVqLO0EWAVM_IE@sellars \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sashiko-bot@kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox