Re: [PATCH] fetch2: do not try to checksum a socket

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 21 June 2012 14:25:56 Richard Purdie wrote:
> It will then attempt to checksum everything in a file:// url which is
> why it finds the socket and then fails. So your change does point at a
> potentially valid issue. Paul might have a better idea on which level we
> might want to fix this at?

Regarding the patch in question, I'm not opposed to a change to avoid errors 
like this, however it looks to me that if the file is missing the 
os.path.isfile() call will return false and bypass the warning that we 
currently show, which would not be desirable. I think it would need to do 
something like call os.stat() and then interpret the results, then we're just 
making one call.

> > Indeed, this was failing for me a couple of weeks ago with a similar
> > SRC_URI. Back then i could not use file:///mydir;protocol=git (i.e.
> > create a clone from a clone living on the local filesystem) so had to
> > resort back to protocol=rsync.
> > There was a socket lying around in that directory, a leftover from
> > some testsuite run.
> 
> FWIW, the url you want is git:///mydir;protocol=file which should work.
> As of the patches today, this also works as mirror syntax so you could
> even add this in local.conf as a PREMIRROR and leave the recipe
> pristine.

Also, if what you want is to have a local source directory you can modify for 
development purposes, you may find the recently added externalsrc.bbclass is 
helpful since that's what it was designed to handle. I guess it depends on 
what you're trying to achieve and what your workflow is.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre