From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joshua Lock <josh@linux.intel.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [RFC PATCH 1/1] Ensure only the filtered environment variables are inherited from the OS
Date: Mon, 15 Aug 2011 09:41:48 +0100 [thread overview]
Message-ID: <1313397708.14274.544.camel@rex> (raw)
In-Reply-To: <0bed22559175a17f0af42f122e719c869f8dc0e7.1313196998.git.josh@linux.intel.com>
On Fri, 2011-08-12 at 17:58 -0700, Joshua Lock wrote:
> The recent change which modified inheritFromOS to use the intial
> environment, rather than the current environment, introduced a bug such
> that variables which had been cleaned from the environment where still set
> in the data store.
>
> This patch changes things such that a list of approved environment
> variables is saved after the environment is cleaned and only the variables
> in this list are inherited in inheritFromOS.
>
> CC: James Limbouris <james.limbouris@gmail.com>
> CC: Chris Larson <clarson@kergoth.com>
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
> bin/bitbake-layers | 6 +++---
> lib/bb/cooker.py | 3 ++-
> lib/bb/data.py | 15 ++++++++-------
> lib/bb/utils.py | 23 ++++++++++++++++-------
> 4 files changed, 29 insertions(+), 18 deletions(-)
Merged to master, thanks.
Richard
prev parent reply other threads:[~2011-08-15 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 0:58 [RFC PATCH 0/1] Don't include cleaned variables in inherited environment Joshua Lock
2011-08-13 0:58 ` [RFC PATCH 1/1] Ensure only the filtered environment variables are inherited from the OS Joshua Lock
2011-08-15 8:41 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313397708.14274.544.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=josh@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox